Skip to content

fix: make sure that use self comes out of formatter when self is used #2885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tstirrat15 merged 1 commit into from
Feb 5, 2026
Merged

fix: make sure that use self comes out of formatter when self is used #2885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/schemadsl/generator/generator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@

case *core.SetOperation_Child_XSelf:
sg.append("self")
sg.flags.Add("self")

Check warning on line 350 in pkg/schemadsl/generator/generator.go

View check run for this annotation

Codecov / codecov/patch

pkg/schemadsl/generator/generator.go#L350 

Added line #L350 was not covered by tests

case *core.SetOperation_Child_ComputedUserset:
sg.append(child.ComputedUserset.Relation)
Expand Down
29 changes: 29 additions & 0 deletions pkg/schemadsl/generator/generator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ definition foos/document {
}
}

// TestFormatting asserts that the input schema gets turned into the output schema
func TestFormatting(t *testing.T) {
type formattingTest struct {
name string
Expand Down Expand Up @@ -413,6 +414,34 @@ definition document {
}`,
`definition document {
relation viewer: user
}`,
},
{
"use self happy path",
`use self

definition user {
relation viewer: user
permission view = viewer + self
}`,
`use self

definition user {
relation viewer: user
permission view = viewer + self
}`,
},
{
"use self unused",
`use self

definition user {
relation viewer: user
permission view = viewer
}`,
`definition user {
relation viewer: user
permission view = viewer
}`,
},
}
Expand Down
Loading