Skip to content

feat: finish LR consistency tests with the fix to the recursive iterator#2881

Open
barakmich wants to merge 3 commits intomainfrom
barakmich/lr_recursive
Open

feat: finish LR consistency tests with the fix to the recursive iterator#2881
barakmich wants to merge 3 commits intomainfrom
barakmich/lr_recursive

Conversation

@barakmich
Copy link
Contributor

Using the RecursiveSentinel as the stand in for each ply of the transitive closure

Description

Testing

References

@barakmich barakmich requested a review from a team as a code owner February 5, 2026 00:13
@barakmich barakmich force-pushed the barakmich/lr_recursive branch from a51fdbb to 1e61428 Compare February 5, 2026 00:15
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.82%. Comparing base (4c9d349) to head (1e61428).

Files with missing lines Patch % Lines
pkg/query/recursive.go 60.00% 22 Missing and 8 partials ⚠️

❌ Your project check has failed because the head coverage (74.82%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2881      +/-   ##
==========================================
+ Coverage   73.81%   74.82%   +1.02%     
==========================================
  Files         484      484              
  Lines       57938    57994      +56     
==========================================
+ Hits        42760    43390     +630     
+ Misses      12145    11564     -581     
- Partials     3033     3040       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants