Skip to content

fix: query both subrelation and ellipses on arrows for IterResources#2879

Merged
barakmich merged 1 commit intomainfrom
barakmich/lr_arrow
Feb 5, 2026
Merged

fix: query both subrelation and ellipses on arrows for IterResources#2879
barakmich merged 1 commit intomainfrom
barakmich/lr_arrow

Conversation

@barakmich
Copy link
Contributor

Description

Testing

References

@barakmich barakmich requested a review from a team as a code owner February 4, 2026 23:00
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 61.70213% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.84%. Comparing base (d753f26) to head (ddcd55f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/query/arrow.go 58.40% 43 Missing and 9 partials ⚠️
pkg/query/build_tree.go 87.50% 1 Missing ⚠️
pkg/query/fixed.go 87.50% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (74.84%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2879      +/-   ##
==========================================
- Coverage   74.89%   74.84%   -0.04%     
==========================================
  Files         484      484              
  Lines       57869    57938      +69     
==========================================
+ Hits        43337    43360      +23     
- Misses      11499    11543      +44     
- Partials     3033     3035       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tstirrat15
tstirrat15 previously approved these changes Feb 4, 2026
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barakmich barakmich merged commit 4c9d349 into main Feb 5, 2026
43 of 45 checks passed
@barakmich barakmich deleted the barakmich/lr_arrow branch February 5, 2026 00:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants