fix: keep watches panel populated when switching to a non-spicedb tab#71
Open
ivanauth wants to merge 1 commit into
Open
fix: keep watches panel populated when switching to a non-spicedb tab#71ivanauth wants to merge 1 commit into
ivanauth wants to merge 1 commit into
Conversation
`onDidChangeActiveTextEditor` was unconditionally calling `performUpdate` whenever the active editor changed. When the new editor was anything other than a `.zed` / `.zed.yaml` / spicedb-tagged file, `performUpdate` fell through to posting `setActiveSchema(null, null)` and `setActiveYaml(null, null)`. The webview then flipped its `isValidFile` flag and rendered the "current editor is not viewing a SpiceDB schema" empty state, hiding the previously-visible watches. Skip the call when the new editor isn't a SpiceDB-related document, so the panel keeps the state of whichever SpiceDB file was last viewed. The predicate matches the one already used in the `'ready'` handler and in the webview's own validity check, factored out as a small pure function (`isSpiceDbDocument`) so the same logic is shared by both call sites and is unit-testable without the VS Code test harness. Closes authzed#63.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63.