Skip to content

[Fraud Protection] Add Configurations#5546

Merged
carmenlau merged 12 commits intoauthgear:feat-fraud-protectionfrom
tung2744:dev-3407
Mar 12, 2026
Merged

[Fraud Protection] Add Configurations#5546
carmenlau merged 12 commits intoauthgear:feat-fraud-protectionfrom
tung2744:dev-3407

Conversation

@tung2744
Copy link
Copy Markdown
Contributor

@tung2744 tung2744 commented Feb 27, 2026

ref DEV-3407
requires

Copy link
Copy Markdown
Contributor

@carmenlau carmenlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed parts 1 and 2 so far, will continue with the rest later. 🙏🏻

Comment thread docs/plans/fraud-protection-implementation.md Outdated
Comment thread docs/plans/fraud-protection-implementation.md
Comment thread docs/plans/fraud-protection-implementation.md Outdated
Copy link
Copy Markdown
Contributor

@carmenlau carmenlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the feature branch and rebase it please? :)

@tung2744
Copy link
Copy Markdown
Contributor Author

Rebased to latest main. Will rebase again after the spec is merged.

Comment thread pkg/lib/config/configsource/resources.go
@carmenlau
Copy link
Copy Markdown
Contributor

Please rebase again, the PR looks good to merge :)

tung2744 and others added 12 commits March 12, 2026 17:30
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tion config

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Compare incoming vs original (not vs hardcoded default) so that a plan
downgrade never blocks saving an already-customised config unchanged.
Also allow nil/omitted fraud_protection (which parses as default) because
it means the caller is not touching the field.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@tung2744
Copy link
Copy Markdown
Contributor Author

Rebased again, thanks!

@carmenlau carmenlau merged commit 75e7871 into authgear:feat-fraud-protection Mar 12, 2026
11 checks passed
tung2744 pushed a commit that referenced this pull request Mar 17, 2026
[Fraud Protection] Add Configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants