Skip to content

Cleanup most of the v1 code#5543

Merged
carmenlau merged 25 commits intoauthgear:mainfrom
tung2744:dev-3215-1
Mar 13, 2026
Merged

Cleanup most of the v1 code#5543
carmenlau merged 25 commits intoauthgear:mainfrom
tung2744:dev-3215-1

Conversation

@tung2744
Copy link
Copy Markdown
Contributor

@tung2744 tung2744 commented Feb 25, 2026

ref DEV-3215
ref DEV-3216

requires:

Copy link
Copy Markdown
Contributor

@carmenlau carmenlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you share more background on this update? Are there any existing projects or clients currently using the interaction / auth v1 UI implementation? If so, what does the migration plan look like, or is a direct switch to v2 UI feasible for them?

@tung2744
Copy link
Copy Markdown
Contributor Author

tung2744 commented Mar 2, 2026

@carmenlau We have already migrated all existing clients to v2, and set the default to v2. What remaining is just to remove the v1 code, which is what this PR for. Note that, interaction is not removed yet. I only removed v1 UI and the authflow v1 code (The intermediate UI between v1 and v2). Note that there a still a few v1 component remain because they seems to be still in use.
I created two issues for the remaining cleanup:
https://linear.app/authgear/issue/DEV-3406/cleanup-remaining-v1-code
https://linear.app/authgear/issue/DEV-3414/cleanup-interaction-engine

@carmenlau
Copy link
Copy Markdown
Contributor

Does this mean there are still projects using the interaction UI? This commit (abc9bb2) looks like it could affect those projects. I think having more context on how the UI has evolved would really help here, would we have a quick call when you have time?

@tung2744
Copy link
Copy Markdown
Contributor Author

tung2744 commented Mar 2, 2026

There should not be projects using interaction UI. Even if there is, we will drop the support.
In this PR, all code path should treat ui implementation to be always v2. So in case there are such projects, they will just see the v2 ui.

@tung2744 tung2744 changed the title Cleanup most of the v1 code [DO NOT MERGE] Cleanup most of the v1 code Mar 11, 2026
@tung2744 tung2744 changed the title [DO NOT MERGE] Cleanup most of the v1 code Cleanup most of the v1 code Mar 12, 2026
@carmenlau carmenlau merged commit af56058 into authgear:main Mar 13, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants