Skip to content

Add issuer/signature sequence test #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bwillis wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add issuer/signature sequence test #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2e335c
Remove console.log
bwillis Aug 12, 2015
515b74d
Fix order spec assertion
bwillis Aug 12, 2015
24645f2
Add spec to verify signed response signature/issuer order
bwillis Aug 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions test/samlp.signedresponse.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ var server = require('./fixture/server');
var request = require('request');
var cheerio = require('cheerio');
var xmlhelper = require('./xmlhelper');
var xmldom = require('xmldom');

describe('samlp signed response', function () {
before(function (done) {
Expand Down Expand Up @@ -35,7 +36,6 @@ describe('samlp signed response', function () {
});

it('should contain a valid signed response', function(){
console.log(signedResponse);
var isValid = xmlhelper.verifySignature(
signedResponse,
server.credentials.cert);
Expand All @@ -57,5 +57,12 @@ describe('samlp signed response', function () {
expect(destination).to.equal('http://destination');
});

it('should have signature after issuer', function(){
var doc = new xmldom.DOMParser().parseFromString(signedResponse);

var signature = doc.documentElement.getElementsByTagName('Signature');

expect(signature[0].previousSibling.nodeName).to.equal('saml:Issuer');
});
});
});
});
2 changes: 1 addition & 1 deletion test/samlp.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe('samlp', function () {

var signature = doc.documentElement.getElementsByTagName('Signature');

expect('saml:Issuer', signature[0].previousSibling.nodeName);
expect(signature[0].previousSibling.nodeName).to.equal('saml:Issuer');
});

it('should use sha256 as default signature algorithm', function(){
Expand Down