Skip to content

refactor(react): optimize member management component#330

Open
chakrihacker wants to merge 1 commit into
feat/member-managementfrom
UIC-940-unexpected-component-re-render
Open

refactor(react): optimize member management component#330
chakrihacker wants to merge 1 commit into
feat/member-managementfrom
UIC-940-unexpected-component-re-render

Conversation

@chakrihacker
Copy link
Copy Markdown
Contributor

Summary

Why

What

Packages

  • packages/core
  • packages/react
  • examples

References

Testing

How can this be verified? Note anything intentionally not covered by tests and why.

  • This change adds unit test coverage
  • Tested for both SPA and RWA flows, all example apps working
  • All existing and new tests complete without errors

Checklist

  • Breaking change
  • Requires docs update
  • Backward compatible

Contributing

);
}

export const OrganizationInvitationTable = React.memo(OrganizationInvitationTableInner);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to the time being we can avoid using memo as it also comes with additional overhead of comparison of props, using the useCallback should be sufficient, we can check on the profiling data and strategy use them instead of allying them on all components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants