Skip to content

fix(core,react): fix ci cd build order#328

Draft
NaveenChand755 wants to merge 1 commit into
mainfrom
fix/-ci-build
Draft

fix(core,react): fix ci cd build order#328
NaveenChand755 wants to merge 1 commit into
mainfrom
fix/-ci-build

Conversation

@NaveenChand755
Copy link
Copy Markdown
Contributor

@NaveenChand755 NaveenChand755 commented Jun 5, 2026

Summary

Removed the standalone type-check CI step because it ran before build, causing TypeScript to resolve against the published npm version of core instead of local source. Type-checking still runs inside each package's build script via turbo, in the correct dependency order.

Why

  1. type-check ran before build in CI, so core's dist/ didn't exist yet
  2. TypeScript fell back to the published npm version of core, missing local type errors

What

  1. Removed the standalone type-check CI step
  2. Type-checking still happens inside each package's build script, in the correct dependency order

Packages

  • packages/core
  • packages/react
  • examples

References

Testing

How can this be verified? Note anything intentionally not covered by tests and why.

  • This change adds unit test coverage
  • Tested for both SPA and RWA flows, all example apps working
  • All existing and new tests complete without errors

Checklist

  • Breaking change
  • Requires docs update
  • Backward compatible

Contributing

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.75%. Comparing base (efd9ddf) to head (e5c6f4e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   89.75%   89.75%           
=======================================
  Files         162      162           
  Lines       13542    13542           
  Branches     1798     1798           
=======================================
  Hits        12155    12155           
  Misses       1387     1387           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NaveenChand755 NaveenChand755 marked this pull request as draft June 5, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants