fix(react): fix mfa dialog similar to other dialog component#327
Open
NaveenChand755 wants to merge 2 commits into
Open
fix(react): fix mfa dialog similar to other dialog component#327NaveenChand755 wants to merge 2 commits into
NaveenChand755 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
========================================
Coverage 89.47% 89.47%
========================================
Files 156 156
Lines 13070 13070
Branches 1419 1805 +386
========================================
Hits 11694 11694
Misses 1376 1376 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rax7389
reviewed
Jun 6, 2026
| aria-describedby="mfa-setup-form" | ||
| className={cn( | ||
| 'w-[400px] max-h-[90vh]', | ||
| 'w-[600px] max-h-[90vh]', |
Contributor
There was a problem hiding this comment.
Found a similar for delete factor confirmation, shall we also fix it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes mfa component page in react-spa-npm example and mfa component dialog with to match other component dialog
Why
margin was broken around mfa component in react-spa-npm example
What
MFA component Dailog width changed to 600
Packages
packages/corepackages/reactexamplesReferences
Before
After
Testing
How can this be verified? Note anything intentionally not covered by tests and why.
Checklist
Contributing