Skip to content

fix(examples): add missing code in react app to handle user_id from url#320

Open
SurajThotakura wants to merge 1 commit into
feat/member-managementfrom
fix/spa-example-minor-fix
Open

fix(examples): add missing code in react app to handle user_id from url#320
SurajThotakura wants to merge 1 commit into
feat/member-managementfrom
fix/spa-example-minor-fix

Conversation

@SurajThotakura
Copy link
Copy Markdown
Member

Here's the PR content for the recent commit on fix/spa-example-minor-fix:


Summary

Adds missing commented-out code in the React SPA (npm) example app's member detail page to handle extracting user_id from the URL params.

Why

The member detail page in react-spa-npm was missing the commented-out hooks (useNavigate, useParams) that are needed to extract the user_id URL parameter. Other example apps (shadcn, next-rwa) already had this scaffolding in place, making this page inconsistent and incomplete for developers following the quickstart guidance.

What

Added the commented-out useNavigate and useParams hooks to examples/react-spa-npm/src/views/member-detail-page.tsx, aligning it with the pattern used in other example apps.

Packages

  • packages/core
  • packages/react
  • examples

References

Related to the member management feature and member detail navigation flow across example apps.

Testing

How can this be verified? Note anything intentionally not covered by tests and why.

  • This change adds unit test coverage
  • Tested for both SPA and RWA flows, all example apps working
  • All existing and new tests complete without errors

Checklist

  • Breaking change
  • Requires docs update
  • Backward compatible

Contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant