fix(examples): add missing code in react app to handle user_id from url#320
Open
SurajThotakura wants to merge 1 commit into
Open
fix(examples): add missing code in react app to handle user_id from url#320SurajThotakura wants to merge 1 commit into
SurajThotakura wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the PR content for the recent commit on
fix/spa-example-minor-fix:Summary
Adds missing commented-out code in the React SPA (npm) example app's member detail page to handle extracting
user_idfrom the URL params.Why
The member detail page in
react-spa-npmwas missing the commented-out hooks (useNavigate,useParams) that are needed to extract theuser_idURL parameter. Other example apps (shadcn, next-rwa) already had this scaffolding in place, making this page inconsistent and incomplete for developers following the quickstart guidance.What
Added the commented-out
useNavigateanduseParamshooks toexamples/react-spa-npm/src/views/member-detail-page.tsx, aligning it with the pattern used in other example apps.Packages
packages/corepackages/reactexamplesReferences
Related to the member management feature and member detail navigation flow across example apps.
Testing
How can this be verified? Note anything intentionally not covered by tests and why.
Checklist
Contributing