UPSTREAM PR #21331: docs: build.md / HSA_OVERRIDE_GFX_VERSION does not exist on Windows#1330
Open
UPSTREAM PR #21331: docs: build.md / HSA_OVERRIDE_GFX_VERSION does not exist on Windows#1330
Conversation
The `HSA_OVERRIDE_GFX_VERSION` variable can be used in ROCm to override an unsupported target architecture with a similar but supported target architecture. This does not and has never worked on Windows. I think the clarification could avoid driving Windows people towards this solution that does not work.
loci-dev
force-pushed
the
main
branch
8 times, most recently
from
a8215be to
34734bc
Compare
loci-dev
force-pushed
the
main
branch
9 times, most recently
from
245e873 to
d101579
Compare
loci-dev
force-pushed
the
main
branch
2 times, most recently
from
63ab8d1 to
7638ab4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: ggml-org/llama.cpp#21331
The
HSA_OVERRIDE_GFX_VERSIONvariable can be used in ROCm to override an unsupported target architecture with a similar but supported target architecture.This does not and has never worked on Windows. I think the clarification could avoid driving Windows people towards this solution that does not work.
Overview
Additional information
Requirements