UPSTREAM PR #20831: cuda : dynamic MMVQ nwarps for narrow matrices#1327
Open
UPSTREAM PR #20831: cuda : dynamic MMVQ nwarps for narrow matrices#1327
Conversation
|
No meaningful performance changes were detected across 124163 analyzed functions in the following binaries: build.bin.libllama.so, build.bin.llama-tts, build.bin.libmtmd.so, build.bin.llama-cvector-generator, build.bin.llama-bench, build.bin.libggml-base.so, build.bin.libggml-cpu.so, build.bin.libggml.so, build.bin.llama-tokenize, build.bin.llama-gemma3-cli, build.bin.llama-gguf-split, build.bin.llama-llava-cli, build.bin.llama-minicpmv-cli, build.bin.llama-quantize, build.bin.llama-qwen2vl-cli. 🔎 Full breakdown: Loci Inspector |
a8215be to
34734bc
Compare
245e873 to
d101579
Compare
7638ab4 to
f1b46d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: ggml-org/llama.cpp#20831
Fix MMVQ TG regression on MoE models from #19478.
#19478 increased
nwarpsto 8 on RDNA3/RDNA4 to better utilize memory bandwidth for bs=1 decode. However,nwarps=8assumes wide weight matrices. MoE expert FFN layers are narrow (512–2048 cols), so most warps have no work but still pay__syncthreads()and shared-memory reduction overhead, causing a net TG regression. This patch dynamically clampsnwarpsbased on the actual matrix width to avoid this.R9700 (gfx1201, RDNA4), ROCm 7.2
MoE (regression fixed):
Dense (no regression):
Full whitelist sweep — llama-2-7b, 1x R9700, tg512, r=5:
W7900 (gfx1100, RDNA3), ROCm 7.1
MoE (regression fixed):
Full whitelist sweep — llama-2-7b, 1x W7900, tg512, r=5:
Note: PR description translated with AI assistance.