Skip to content

UPSTREAM PR #21203: server: respect the ignore eos flag#1320

Open
loci-dev wants to merge 1 commit intomainfrom
loci/pr-21203-master
Open

UPSTREAM PR #21203: server: respect the ignore eos flag#1320
loci-dev wants to merge 1 commit intomainfrom
loci/pr-21203-master

Conversation

@loci-dev
Copy link
Copy Markdown

Note

Source pull request: ggml-org/llama.cpp#21203

Overview

ignore_eos=true in /completion requests has no effect. server_routes captures a reference to common_params before model loading, but logit_bias_eog is populated after model loading. The captured copy is always empty, so no biases are applied.

Regression test added: sends ignore_eos=true and verifies logit_bias contains EOG entries with -inf bias.

pushd tools/server/tests
LLAMA_SERVER_BIN_PATH=../../../build/bin/llama-server \
  uv run --with-requirements requirements.txt \
    pytest unit/test_ignore_eos.py -v -x
popd

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES - AI was used to draft the regression test and review the fix

@loci-review
Copy link
Copy Markdown

loci-review bot commented Mar 31, 2026

No summary available at this time. Visit Loci Inspector to review detailed analysis.

@loci-dev loci-dev force-pushed the main branch 12 times, most recently from 126cd1f to a8215be Compare April 8, 2026 02:18
@loci-dev loci-dev force-pushed the main branch 7 times, most recently from e800934 to a024d9c Compare April 15, 2026 02:19
@loci-dev loci-dev force-pushed the main branch 6 times, most recently from 7638ab4 to f1b46d5 Compare April 20, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants