Skip to content

Allow coaxial pipe tests to run on CI #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajdubas merged 3 commits into from
Jan 19, 2026
Merged

Allow coaxial pipe tests to run on CI #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3baec52
Attempt to use two processes for coaxial pipe tests
mattfalcone1997 Jan 15, 2026
b861b80
Reduce computational cost of coaxial pipe tests so that the non-heavy
mattfalcone1997 Jan 15, 2026
5187af4
Make sure unit test runs for heavy tests
mattfalcone1997 Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/tests/components/coaxial_pipe/energy_balance.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ qw = 1e4
[coaxial]
type = CoaxialPipe1Phase
length = ${L}
n_elems = 100
n_elems = 20
orientation = '1 0 0'
position = '0 0 0'
shell_inner_radius = 0.075
Expand Down
2 changes: 1 addition & 1 deletion test/tests/components/coaxial_pipe/energy_balance_inner.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ qw = 1e4
[coaxial]
type = CoaxialPipe1Phase
length = ${L}
n_elems = 100
n_elems = 20
orientation = '1 0 0'
position = '0 0 0'
shell_inner_radius = 0.075
Expand Down
2 changes: 1 addition & 1 deletion test/tests/components/coaxial_pipe/energy_balance_outer.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ qw = 1e4
[coaxial]
type = CoaxialPipe1Phase
length = ${L}
n_elems = 100
n_elems = 20
orientation = '1 0 0'
position = '0 0 0'
shell_inner_radius = 0.075
Expand Down
4 changes: 2 additions & 2 deletions test/tests/components/coaxial_pipe/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def test_energy_balance(self):
total_energy = m_dot*cp*(delta_t_inner + delta_t_outer)

rel_diff = abs(total_energy - q)/q
assert rel_diff < 0.00025, f"Rel. energy difference greater than 0.00025: {rel_diff}"
assert rel_diff < 0.00028, f"Rel. energy difference greater than 0.00025: {rel_diff}"

def test_energy_balance_inner(self):
"""Compares energy increase in the inner pipe to heat flux input on shell exterior."""
Expand Down Expand Up @@ -73,4 +73,4 @@ def test_energy_balance_outer(self):
total_energy = m_dot*cp*delta_t_outer

rel_diff = abs(total_energy - q)/q
assert rel_diff < 0.00046, f"Rel. energy difference greater than 0.00046: {rel_diff}"
assert rel_diff < 0.00048, f"Rel. energy difference greater than 0.00046: {rel_diff}"
13 changes: 4 additions & 9 deletions test/tests/components/coaxial_pipe/tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,13 @@
[fp_err]
type = RunException
input = energy_balance.i
min_parallel = 4
max_parallel = 4
requirement = "Checks that copyParamFromParamWithGlobal works properly"
expect_err = "Either inner_fp or fp must be set"
[]
[energy_balance_global]
[run]
type = RunApp
input = energy_balance.i
min_parallel = 4
max_parallel = 4
requirement = "Checks energy balance for the coaxial pipe"
cli_args = "GlobalParams/fp=fluid"
[]
Expand All @@ -27,15 +23,16 @@
[run]
type = RunApp
input = energy_balance_inner.i
min_parallel = 4
max_parallel = 4
min_parallel = 2
max_parallel = 2
heavy=true
max_time = 7200
[]
[test]
type= PythonUnitTest
input = test.py
test_case = TestCoaxialPipe.test_energy_balance_outer
heavy=true
prereq = energy_balance_inner/run
[]
requirement = "Checks that inner pipe conserved energy in isolation"
Expand All @@ -44,8 +41,6 @@
[run]
type = RunApp
input = energy_balance_outer.i
min_parallel = 4
max_parallel = 4
[]
[test]
type= PythonUnitTest
Expand All @@ -55,4 +50,4 @@
[]
requirement = "Checks that outer pipe conserved energy in isolation"
[]
[]
[]
Loading