Skip to content

Add coaxial junction to join two coaxial pipes together#52

Merged
ajdubas merged 8 commits intomainfrom
coaxial-junction
Feb 23, 2026
Merged

Add coaxial junction to join two coaxial pipes together#52
ajdubas merged 8 commits intomainfrom
coaxial-junction

Conversation

@mattfalcone1997
Copy link
Collaborator

@mattfalcone1997 mattfalcone1997 commented Jan 7, 2026

This junction allows the coaxial tubes of different geometries to be joined. In this implementation, both the solid region and fluid regions are connected, with the flow channels are optionally joined. This allows components such as pumps may be added. Currently, the flow junctions are assumed to have no momentum loss, which can be improved in the future if necessary.

Considerations

  • Coupling solid regions with different geometries is not straightforward here, as existing coupling components require a one-to-one element mapping. This significantly restricts geometry variation.
    • This can be remedied by implementing a slightly different variation of the 2D coupling component.
    • This can be added if it is found to be necessary.

Testing

  • Tests verifying solid coupling
  • Tests ensuring continuity of mass flow rate
  • Tests to show that error are raised correctly
  • Await merge of coaxial pipe

@mattfalcone1997 mattfalcone1997 marked this pull request as ready for review January 8, 2026 10:42
@ajdubas ajdubas merged commit fdd57e8 into main Feb 23, 2026
9 of 14 checks passed
@ajdubas ajdubas deleted the coaxial-junction branch February 23, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants