Skip to content

Fix release workspace version bump#173

Merged
R-M-Naveen merged 1 commit into
mainfrom
naveen/release-workflow-version-bump
May 29, 2026
Merged

Fix release workspace version bump#173
R-M-Naveen merged 1 commit into
mainfrom
naveen/release-workflow-version-bump

Conversation

@R-M-Naveen
Copy link
Copy Markdown
Member

Summary

  • replace workspace npm version calls in the release workflow with npm pkg set version
  • avoids implicit workspace-local installs that can create nested packages/*/node_modules
  • keeps the final npm install so the lockfile is regenerated after versions and internal dependency ranges are updated

Why

The v0.11.9 release rerun checked out main but failed tests because release-time workspace versioning created nested package installs that shadowed local workspaces with already-published @atxp packages. That made tests import stale 0.11.8 code during the 0.11.9 release.

Validation

  • Simulated the release version-bump step in /tmp using npm pkg set version=0.11.9 and confirmed @atxp/client resolves @atxp/common@0.11.9 to the local workspace
  • npx -y -p node@22 -p npm@10 npm run build in the simulated release worktree
  • npx -y -p node@22 -p npm@10 npm test -w packages/atxp-client
  • npx -y -p node@22 -p npm@10 npm test -w packages/atxp-express
  • npx -y -p node@22 -p npm@10 npm test -w packages/atxp-server

@R-M-Naveen R-M-Naveen merged commit 7b9cd38 into main May 29, 2026
1 check passed
@R-M-Naveen R-M-Naveen deleted the naveen/release-workflow-version-bump branch May 29, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant