Fix release workspace version bump#173
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm versioncalls in the release workflow withnpm pkg set versionpackages/*/node_modulesnpm installso the lockfile is regenerated after versions and internal dependency ranges are updatedWhy
The v0.11.9 release rerun checked out main but failed tests because release-time workspace versioning created nested package installs that shadowed local workspaces with already-published @atxp packages. That made tests import stale 0.11.8 code during the 0.11.9 release.
Validation
npm pkg set version=0.11.9and confirmed@atxp/clientresolves@atxp/common@0.11.9to the local workspacenpx -y -p node@22 -p npm@10 npm run buildin the simulated release worktreenpx -y -p node@22 -p npm@10 npm test -w packages/atxp-clientnpx -y -p node@22 -p npm@10 npm test -w packages/atxp-expressnpx -y -p node@22 -p npm@10 npm test -w packages/atxp-server