Skip to content

Fix express fetch stub isolation #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
R-M-Naveen merged 2 commits into from
May 28, 2026
Merged

Fix express fetch stub isolation #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
661f206
test: run workspace vitest files serially
R-M-Naveen May 28, 2026
3bd329d
test: isolate express fetch stubs
R-M-Naveen May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/atxp-express/src/omniChallenge.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { describe, it, expect, vi, beforeEach } from 'vitest';
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import { atxpExpress } from './atxpExpress.js';
import * as TH from '@atxp/server/serverTestHelpers';
import { getDetectedCredential, type DetectedCredential } from '@atxp/server';
Expand All @@ -7,12 +7,16 @@ import request from 'supertest';

// Mock global fetch — middleware no longer calls settle, so fetch should not be called
const mockFetch = vi.fn();
vi.stubGlobal('fetch', mockFetch);

describe('credential detection Express middleware', () => {

beforeEach(() => {
mockFetch.mockReset();
vi.stubGlobal('fetch', mockFetch);
});

afterEach(() => {
vi.unstubAllGlobals();
});

describe('credential detected → stored in context, handler proceeds', () => {
Expand Down
Loading