Carry resource metadata in MPP challenges#170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Accounts/auth can already preserve and record MPP destination resources, but live Music MPP challenges only carried the payment recipient. When several products share the same ATXP destination account, recipient-only rows fall back to the shared account label, which made Music appear as ATXP LLM Server.
Safety
This does not change payment amount, token, recipient, chain, fee payer, or transaction verification. I checked mppx@0.5.10 locally: top-level unknown challenge fields are stripped, but challenge.request is an open record and request.resource survives Credential.serialize/deserialize. Tempo createCredential/verify use amount/currency/recipient/methodDetails and ignore the extra request.resource metadata.
Validation