chore(bench-arena): label the Attaform rows by zod major (Zod 3 / Zod 4)#411
Merged
Conversation
…d@v4) The benchmark's two Attaform rows were "Attaform" and "Attaform (Zod 4)". The bare "Attaform" left a reader to infer it is the zod-v3 adapter, which is not obvious at a glance. Rename both displayName labels to "Attaform (zod@v3)" and "Attaform (zod@v4)" so the comparison table names the zod major on each row explicitly. The labels live in each adapter's meta (the source the bench bakes into results.json); the two committed results.json displayName fields are updated to match so the docs render the new names now, and the next refresh regenerates them identically from the meta. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Match the capability table's schema-column style (SCHEMA_LABEL's "Zod 3" / "Zod 4") rather than the "zod@vN" form. The v4 row returns to its original "Attaform (Zod 4)"; only the v3 row gains the explicit "(Zod 3)". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ozzyfromspace
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The benchmark comparison table labeled Attaform's two rows as Attaform and Attaform (Zod 4).
The bare "Attaform" leaves a reader to infer it is the zod-v3 adapter, which is not obvious at a
glance. This makes the zod major explicit on both rows, in the "Zod 3" / "Zod 4" style the capability
table's schema column already uses:
Attaformbecomes Attaform (Zod 3)Attaform (Zod 4)is unchangedWhere
The label is each adapter's
meta.displayName, which the bench bakes intoresults.jsonand thedocs render (
BenchArena.vuereadscapabilities[].displayName). So this updates:apps/bench-arena/src/adapters/attaform/adapter.ts), the source of truthdisplayNamefield in the committedresults.json, so the docs show the new labelimmediately
Net effect: only the v3 row gains the explicit "(Zod 3)"; the v4 row keeps "Attaform (Zod 4)". The
next bench refresh regenerates
results.jsonfrom the adapter metas, producing the same labels.🤖 Generated with Claude Code