Skip to content

docs: c-protected-header-files decision#216

Draft
xavierchanth wants to merge 1 commit intotrunkfrom
c-protected-header-files
Draft

docs: c-protected-header-files decision#216
xavierchanth wants to merge 1 commit intotrunkfrom
c-protected-header-files

Conversation

@xavierchanth
Copy link
Member

@xavierchanth xavierchanth commented Jan 3, 2025

- What I did

  • Added a new decision log, please read the document

- How I did it

- How to verify it

- Description for the changelog
docs: c-protected-header-files decision

@xavierchanth
Copy link
Member Author

Will discuss tomorrow on call

@xavierchanth xavierchanth requested a review from cconstab January 7, 2025 15:38
Copy link
Member

@cpswan cpswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xavierchanth what's your preferred option (and why)?

I think it's fine to go into these things with an answer (and other things that were considered). Maybe it surfaces additional reasons for the other options to be (re)considered, but generally I think people will be happy to go with the suggested approach.

As I recall, the purpose of this ADR was to leave a record of why we started doing the thing, so let's not agonise too much over how we do it.

@xavierchanth
Copy link
Member Author

@xavierchanth what's your preferred option (and why)?

I think it's fine to go into these things with an answer (and other things that were considered). Maybe it surfaces additional reasons for the other options to be (re)considered, but generally I think people will be happy to go with the suggested approach.

As I recall, the purpose of this ADR was to leave a record of why we started doing the thing, so let's not agonise too much over how we do it.

My plan is to try A, and see if it reasonably fulfills our needs, if not, we can try B or another option if it appears. Once we have a clear answer, I'll update the document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants