fix: pass through extra Slack API params in convenience methods#32
Draft
Koan-Bot wants to merge 2 commits into
Draft
fix: pass through extra Slack API params in convenience methods#32Koan-Bot wants to merge 2 commits into
Koan-Bot wants to merge 2 commits into
Conversation
post_ok, post_warning, post_error, post_info, post_start, and post_end silently dropped any option not in their known set (color, title, text, body, content, post_text). This meant users couldn't use Slack features like thread_ts or unfurl_links with convenience methods — they had to fall back to the raw post() method and lose preset styling. Now, unrecognized key-value options are passed through to the top-level Slack payload, enabling threaded replies, unfurl control, etc. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
cpm now requires Perl 5.24+, breaking CI for older Perl versions in the Docker-based matrix. cpanm supports Perl 5.8+ and handles cpanfile installation identically. The ubuntu job (system Perl 5.38) keeps cpm since it works fine there. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Convenience methods (
post_ok,post_warning, etc.) now pass through unrecognized key-value options to the top-level Slack payload instead of silently dropping them.Why
Users wanting threaded replies or unfurl control with styled messages had to abandon convenience methods and use raw
post(), losing preset colors/attachments. This was a silent data loss — no error, no warning, just dropped parameters.How
After building the attachments hash, any key not in the reserved set (
color,title,text,body,content,post_text) is forwarded to the top-level data hash. Single-arg calls are unaffected.Testing
thread_tspassthrough, multiple extra options, single-arg no-leak🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 95 insertions(+), 1 deletion(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline