test: expand coverage and clean up misleading Content-Type#14
Closed
Koan-Bot wants to merge 1 commit into
Closed
Conversation
Add test coverage for previously untested paths: - post_info (both text and key-value forms) - post() with too many arguments - notify_slack() direct call with single string - notify_slack() content and body aliases for text - notify_slack() error paths (zero args, odd args) - auto_detect_utf8 => 0 disabled mode Also: - Remove misleading Content-Type header from _build__http: post_form() always sends application/x-www-form-urlencoded, so the JSON header was dead code that confused readers. - Fix POD typo: "layour" → "layout" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Expand test coverage from 46 to 64 tests and remove dead code.
Why
Several public APIs had zero test coverage (
post_info,notify_slackdirect call,content/bodyaliases,auto_detect_utf8 => 0mode). TheContent-Type: application/jsondefault header in_build__httpwas misleading —post_form()always sendsapplication/x-www-form-urlencoded, so the header was never used.How
default_headersfrom HTTP::Tiny constructorTesting
prove -Ilib -v t/hooks.t— 64/64 pass locally.🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 168 insertions(+), 9 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline