test: lifecycle callback edge cases#36
Draft
Koan-Bot wants to merge 1 commit into
Draft
Conversation
Cover contracts and interactions for _before_build, build(), _after_build that aren't tested elsewhere: return value semantics, hook firing during callbacks, exception propagation, and constructor arg visibility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add 22 tests covering lifecycle callback contracts that aren't exercised by existing test files.
Why
The existing tests verify individual callback behaviors, but several edge cases around their interactions were untested:
_before_build/_after_buildreturn values are silently ignored (unlike_before_*attribute hooks) -- this contract was undocumented by tests_after_buildandbuild()callbacks_before_buildsees all constructor args including unknown ones (before strict constructor rejects them)_before_buildTesting
All 22 new tests pass. Full suite passes across all existing test files.
🤖 Generated with Claude Code
Quality Report
Changes: 1 file changed, 227 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline