Fix globalcontext_destroy leaks#2356
Open
petermm wants to merge 1 commit into
Open
Conversation
pguyot
approved these changes
Jul 4, 2026
pguyot
left a comment
Collaborator
There was a problem hiding this comment.
We probably can squash this in a single commit
Fix modules table cleanup on globalcontext_new errors Use valueshashtable_destroy when unwinding after modules_table has been allocated so its buckets and SMP lock are released consistently with normal GlobalContext teardown. Signed-off-by: Peter M <petermm@gmail.com>
131dbf5 to
f283ce2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced when doing test_main.c work for zephyr CI.
Knew they were there, should help the esp32 test_main.c harness, especially on the low memory boards and wifi tests.
Mostly (only?) relevant in those scenarios.
note that there is still a leak for: "atom_table_destroy still does not free atom strings allocated with AtomTableCopyAtom."
llm tells me:
but that is punted for a follow up.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later