Ensures factor bundle correctly matches entries to output streams#64
Open
eggyal wants to merge 2 commits intoatomify:masterfrom
eggyal:matchFBOutputsToEntries
Open
Ensures factor bundle correctly matches entries to output streams#64eggyal wants to merge 2 commits intoatomify:masterfrom eggyal:matchFBOutputsToEntries
eggyal wants to merge 2 commits intoatomify:masterfrom
eggyal:matchFBOutputsToEntries
Conversation
Author
|
One should probably give users the choice of receiving full paths in return, instead of abbreviated versions (otherwise name collisions could arise: e.g. if See https://github.com/eggyal/atomify-js/commit/4961bef94fac6ec1e0643b92315a92d34c3627a5 |
Contributor
|
Seems like a good idea. Can you take a look at the test failure? |
Contributor
|
hmmm… I think the test failure will be resolved if you rebase on master. |
The documentation for [`_.values(object)`](https://lodash.com/docs#values) gives an example: > _.values(new Foo); > // → [1, 2] (iteration order is not guaranteed) Since "iteration order is not guaranteed", the array of streams passed to factor-bundle may not be in the same order as the corresponding files in `entries`. Factor bundle [depends on this correlation](https://github.com/substack/factor-bundle/blob/master/index.js#L73) when building its pipeline. This commit ensures that there is never a mismatch.
Author
|
@joeybaker: Rebased; tests passing! |
Contributor
|
@eggyal thanks! I like your idea of adding the option. Mind adding that into this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for
_.values(object)gives an example:Since "iteration order is not guaranteed", the array of streams passed to factor-bundle may not be in the same order as the corresponding files in
entries. Factor bundle depends on this correlation when building its pipeline.This commit ensures that there is never a mismatch.