Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
web-serial-plotter | a288e2c | Commit Preview URL Branch Preview URL |
Oct 01 2025, 09:29 PM |
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to hide and show individual plot traces by introducing a visible property to series data and updating the UI to provide checkboxes in the stats panels. This allows users to selectively display only the traces they want to see.
- Adds a
visible: booleanproperty to thePlotSeriesinterface - Updates plot rendering logic to skip hidden series in drawing and y-axis calculations
- Adds checkboxes to stats panels for toggling trace visibility with visual feedback
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/plot.ts | Adds visible boolean property to PlotSeries interface |
| src/store/RingStore.ts | Implements visibility toggling functionality and excludes hidden series from y-range calculations |
| src/utils/plotRendering.ts | Updates drawing functions to skip hidden series |
| src/components/StatsPanel.tsx | Adds visibility checkboxes and conditional stats computation |
| src/components/Legend.tsx | Filters legend to only show visible series |
| Test files | Updates test data to include the new visible property |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to hide and show traxces.
Motivation & Context
Closes #14
Changes
Adds a checkbox to the stats panels that lets you turn traces off and on.
Screenshots / Demos (if UI)
How to Test
Checklist
npm run lintand fixed any issuesnpm run typecheck(TypeScript) with no errorsnpm testand tests passnpm run test:coverageif code paths changed significantlyAdditional Notes
I thought about doing this in the legend, but felt that might get a bit busy.