Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
web-serial-plotter | 688628b | Commit Preview URL Branch Preview URL |
Sep 19 2025, 09:42 PM |
There was a problem hiding this comment.
Pull Request Overview
This PR adds additional lower baud rate options (300, 600, 1200, 2400, 4800) to the serial communication interface, expanding the range of supported connection speeds for legacy devices or specific hardware requirements.
- Extends the BaudRate type definition to include 5 additional lower baud rates
- Updates the ConnectModal component to display the new baud rate options in the UI
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/hooks/useSerial.ts | Adds lower baud rates (300-4800) to the BaudRate type definition |
| src/components/ConnectModal.tsx | Updates the BAUD_RATES array to include the new lower baud rate options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds additional baud rates.
Motivation & Context
Closes #9
Changes
Adds more baud rates to the ConnectModal and the useSerial components.
Screenshots / Demos (if UI)
How to Test
1 Click the connect button
2 Try one of the new baud rates
Checklist
npm run lintand fixed any issuesnpm run typecheck(TypeScript) with no errorsnpm testand tests passnpm run test:coverageif code paths changed significantlyAdditional Notes
At some point we might want to have a free text for this field.