This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Conversation
add visual studio to PATH on appveyor
Contributor
Author
|
@darangi @sadick254 Consider this and #52 if you had time :). Pretty straight forward updates. |
sadick254
reviewed
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
It uses my joanna fork which supports parsing new JavaScript. If you merge that PR, we can use the package itself. atom/joanna#12.
Benefits
By using non-transformed code, users can use ES6 classes. This is useful since babel transformation converts the ES6 classes to prototypical functions. By including the lib folder, the users can opt into using the ES6 class code by requiring the
event-kit/lib/event-kitAllows us to modernize event-kit code in the future PRs (see Optimizations (Parcel + CompositeDisposable + Disposable + Emitter) #52)
Verification
All the tests pass:
