Remove duplicate wait time on translog archive batch#2
Open
axieatlas wants to merge 2 commits into
Open
Conversation
The buffered interval time has been waited on BufferedAsyncIOProcessorBatching, translog archive batch coordiantor does not need to wait for another buffer interval to batch multiple shards translogs.
… batch is uploaded will be uploaded immediately after the first batch completes No caller of timerDispatcher in code
hnguyen10atlassian
added a commit
that referenced
this pull request
May 27, 2026
…reshold
Wire fallbackStrategies() in downloadOnce():
- If primary strategy's downloadRange() throws IOException, core iterates
strategy.fallbackStrategies() in order until one succeeds.
- Enables safe rolling upgrades: TAR strategy can declare DefaultRemote
StoreTranslogStrategy as fallback so per-file blobs written before the
strategy switch are still recoverable.
- Default fallbackStrategies() returns empty list — no change for stable
strategy deployments.
Note: globalCheckpoint wiring into ShardReport (Fix #2) requires threading
through TransferSnapshot → TranslogTransferMetadata which touches many
construction sites. Deferred to a follow-up — current default of Long.MAX_VALUE
is conservative (never GCs early) so correctness is maintained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The buffered interval time has been waited on BufferedAsyncIOProcessorBatching, translog archive batch coordiantor does not need to wait for another buffer interval to batch multiple shards translogs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.