Skip to content

feat: add AI-ready infrastructure with commands, skills, and ADRs#1140

Open
AtMrun wants to merge 1 commit intomainfrom
feat/ai-ready-infrastructure
Open

feat: add AI-ready infrastructure with commands, skills, and ADRs#1140
AtMrun wants to merge 1 commit intomainfrom
feat/ai-ready-infrastructure

Conversation

@AtMrun
Copy link
Copy Markdown
Collaborator

@AtMrun AtMrun commented Mar 19, 2026

Summary

  • Add agent-executable infrastructure so AI coding assistants (Claude Code, Copilot, Cursor, Devin) can execute tasks in the SDK, not just read about it
  • 24 new files + 1 modified file + 1 symlink across commands, skills, ADRs, and anti-patterns
  • Follows patterns proven in the automation-engine repo

Changes

Foundation

  • CLAUDE.md: Added 10 critical anti-patterns section with wrong/right code snippets (bare except, blocking async, missing types, deep nesting, N+1 queries, string concat, mutable defaults, to_pandas, missing heartbeater, sensitive logs)
  • AGENTS.md: Converted from standalone file to symlink → CLAUDE.md for multi-tool compatibility
  • .claude/settings.json: Enables GitHub plugin

Architecture Decision Records (docs/decisions/)

  • 0001-temporal-activity-patterns.md — Class-based activities, Generic state, heartbeating, 15-min auto-refresh
  • 0002-objectstore-path-semantics.md — Path normalization via as_store_key(), key/prefix vs local file params
  • 0003-client-inheritance-hierarchy.md — Three-tier hierarchy: ClientInterface → BaseClient → BaseSQLClient
  • 0004-interceptor-chain-design.md — Cross-cutting concerns as separate interceptors

Slash Commands (.claude/commands/)

  • create-client — Build HTTP or SQL clients
  • create-activity — Temporal activities with state + heartbeating
  • create-workflow — Temporal workflows with retry/timeout policies
  • create-handler — Handlers bridging clients and activities
  • create-transformer — Metadata transformers with Daft DataFrames
  • write-tests — pytest with AAA pattern, 85% coverage target
  • fix-precommit — Diagnose and fix pre-commit failures
  • create-pr — Generate PRs with conventional commit format

Skills (.claude/skills/)

  • clients/ — HTTP and SQL client patterns
  • activities/ — Temporal activity lifecycle
  • workflows/ — Workflow composition and determinism
  • handlers/ — Handler interface implementation
  • transformers/ — Daft DataFrame transformations
  • services/ — ObjectStore, StateStore, SecretStore, EventStore via Dapr
  • observability/ — Structured logging, metrics, tracing
  • io/ — Parquet and JSON file I/O

Testing

  • Verified file structure: find .claude/ -type f | sort — 10 command files, 8 skill files
  • Verified symlink: ls -la AGENTS.md → points to CLAUDE.md
  • Verified ADRs: ls docs/decisions/ — README + 4 ADRs
  • All files are markdown — no code changes, no runtime impact

Documentation

All new files are documentation. ADRs reference specific source files. Commands and skills reference both ADRs and source files for progressive disclosure.

Add agent-executable infrastructure so AI coding assistants can
execute tasks (not just read about them) in the application-sdk:

- CLAUDE.md: add 10 critical anti-patterns with code examples
- AGENTS.md: symlink to CLAUDE.md for multi-tool compatibility
- 4 ADRs: Temporal activities, ObjectStore paths, client hierarchy,
  interceptor chain design
- 8 slash commands: create-client, create-activity, create-workflow,
  create-handler, create-transformer, write-tests, fix-precommit,
  create-pr
- 8 skills: clients, activities, workflows, handlers, transformers,
  services, observability, io
@snykgituser
Copy link
Copy Markdown

snykgituser commented Mar 19, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants