Add missing JsCallbackLoadableValue to demo callback#2287
Draft
Add missing JsCallbackLoadableValue to demo callback#2287
Conversation
mvorisek
commented
May 9, 2025
|
|
||
| return new JsToast('This country name can be added.'); | ||
| }, ['args' => [$nameInput->jsInput()->val()]]); | ||
| }, ['args' => [new JsCallbackLoadableValue($nameInput->jsInput()->val(), static fn ($v) => $v)]]); |
Member
Author
There was a problem hiding this comment.
TODO for myself - can this be detected using phpstan or no lately on runtime?
There was a problem hiding this comment.
It works for me, but looks like black magic, not low code :)
Member
Author
There was a problem hiding this comment.
Low code, but still we require explicit code to enforce strong typecasting. Here we indicate we want to keep string type.
With improve method param type PHPStan should be able to detect the issue.
Also we should throw if the type is not JsCallbackLoadableValue in JsCallback. The reason you got "argument error" is passed JsExpression implements __call. I will work on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2286