Draft
Conversation
mvorisek
force-pushed
the
crud_in_form
branch
11 times, most recently
from
70eb924 to
196e4e8
Compare
mvorisek
force-pushed
the
crud_in_form
branch
16 times, most recently
from
05a4b64 to
f8b0fb5
Compare
mvorisek
force-pushed
the
crud_in_form
branch
2 times, most recently
from
877921b to
f4ae384
Compare
mvorisek
force-pushed
the
crud_in_form
branch
2 times, most recently
from
e1541df to
5950975
Compare
mvorisek
force-pushed
the
crud_in_form
branch
2 times, most recently
from
bb05054 to
907f6b8
Compare
mvorisek
force-pushed
the
crud_in_form
branch
3 times, most recently
from
517ddc8 to
942ee5a
Compare
mvorisek
force-pushed
the
crud_in_form
branch
from
942ee5a to
ee5a87a
Compare
mvorisek
force-pushed
the
crud_in_form
branch
2 times, most recently
from
7304da1 to
c68de35
Compare
mvorisek
force-pushed
the
crud_in_form
branch
from
c68de35 to
7433607
Compare
mvorisek
force-pushed
the
crud_in_form
branch
from
7433607 to
e6f8c99
Compare
mvorisek
force-pushed
the
crud_in_form
branch
2 times, most recently
from
c5f3051 to
a53fb8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank to #2031 we can test cross request changes reliably.
This PR should fix #1375 and #1860 (TODO review before merge) and related atk4/data#881 and atk4/data#1004.
The Form/Crud components for child records work on virtualized database which produces serialized state managed by the main Form and thus no changes are done on the real database until the main Form is submit.
TODO cover (or delete) https://app.codecov.io/gh/atk4/ui/commit/04aba5baff5a8f00747aaa851d34ed49ce3e3995/blob/src/Form/Control/Multiline.php#L430
might need fomantic/Fomantic-UI#2792, fomantic/Fomantic-UI#2944