Add multi column decorator support in CardTable#1959
Draft
DarkSide666 wants to merge 2 commits intodevelopfrom
Draft
Add multi column decorator support in CardTable#1959DarkSide666 wants to merge 2 commits intodevelopfrom
DarkSide666 wants to merge 2 commits intodevelopfrom
Conversation
mvorisek
force-pushed
the
feature/flag-cardtable
branch
from
cab3579 to
2a2bb5f
Compare
mvorisek
force-pushed
the
feature/flag-cardtable
branch
10 times, most recently
from
a3b7c34 to
21d0613
Compare
mvorisek
changed the title
mvorisek
changed the title
mvorisek
changed the title
mvorisek
changed the title
mvorisek
force-pushed
the
feature/flag-cardtable
branch
from
21d0613 to
31d5af5
Compare
mvorisek
force-pushed
the
feature/flag-cardtable
branch
3 times, most recently
from
6a61ef6 to
c9f060f
Compare
mvorisek
force-pushed
the
feature/flag-cardtable
branch
from
c9f060f to
9dc8705
Compare
Member
|
@DarkSide666 please rebase this PR |
mvorisek
reviewed
Nov 23, 2024
| CardTable::addTo($app)->setModel($entity); | ||
|
|
||
| // CardTable uses internally atk4_local_object type which uses weak references, | ||
| // force GC to test the data are kept referenced correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously value was typecasted to UI string wrongly when building the data, but the data for later formatting are expected to in native datatype (like
bool)TODO render country name in flag tooltip and add test asserting the format and asserting no reload