Conversation
src/Menu.php
Outdated
| if (isset($name['icon'])) { | ||
| Icon::addTo($group, [$name['icon']], ['Icon'])->removeClass('item'); | ||
| } elseif (isset($name['label'])) { | ||
| Label::addTo($group, [$name['label']], ['Icon'])->removeClass('item')->addClass('mini'); |
There was a problem hiding this comment.
you say this is supported somewhere and somewhere not - can we dedup the code at least with private method?
mvorisek
left a comment
mvorisek
left a comment
There was a problem hiding this comment.
need at least a test in demos - to cover the added lines
|
It is supported for menu items, but not for groups - groups were added outside of Fomantic UI, whereas menuitems are rendered based on standard FUI. Will work on demo |
mvorisek
changed the title
mvorisek
force-pushed
the
feature/menugroup_label
branch
from
bc372fe to
70c8a14
Compare
| if (isset($name['icon'])) { | ||
| Icon::addTo($group, [$name['icon']], ['Icon'])->removeClass('item'); | ||
| } elseif (isset($name['label'])) { | ||
| Label::addTo($group, [$name['label']], ['Icon'])->removeClass('item')->addClass('tiny'); |
There was a problem hiding this comment.
for menu item the size is standard (class is unspecified) - ie. the font size is 12 px
for menu group, the size should not be smaller (tiny is 9 px)
related with https://github.com/atk4/ui/pull/1847/files#r1548874861 which should be solved first/instead
|
|
||
| if (isset($name['icon'])) { | ||
| Icon::addTo($group, [$name['icon']], ['Icon'])->removeClass('item'); | ||
| } elseif (isset($name['label'])) { |
There was a problem hiding this comment.
Caveat: It would be better if the items were right-aligned (the icon or the label) - for menu items (see below), they are right aligned, so the label spreads out to the left. If anyone has a hint, how to set classes for that please contribute.
The solution is probably to implement the "menu group item" the same way as "menu item", currently the HTML/CSS for "menu group item" is using CSS/FUI columns, but "menu item" right float positioning.
There was a problem hiding this comment.
in 93ac62f I have commit debug code to debug/unify this
also IMO Maestro layout should be integrated into parametrized Admin layout
mvorisek
force-pushed
the
feature/menugroup_label
branch
from
27b601d to
93ac62f
Compare
2 participants
Situation:
Today, only icons are supported for menu groups. Menu items however in Admin or Maestro layout can show either an icon or a label.
PR:
Introduce to add label also for menu groups.
Sample Usage:
$layout->addMenuGroup(['Tickets', 'label' => ['1', 'class.red' => true]]);Look:
Caveat: It would be better if the items were right-aligned (the icon or the label) - for menu items (see below), they are right aligned, so the label spreads out to the left. If anyone has a hint, how to set classes for that please contribute.