This repository was archived by the owner on Apr 16, 2022. It is now read-only.
Open
Conversation
DarkSide666
changed the title
DarkSide666
suggested changes
Apr 8, 2019
Member
DarkSide666
left a comment
DarkSide666
left a comment
There was a problem hiding this comment.
Theoretically looks good, but need to add some tests to validate that it works in all cases.
Member
|
Thanks for your contribution @pmvcoelho! This drops "setOrder" method, is that OK, Imatns? Would that be a BC break ? also - I'd like to see why this change is needed and what are some use-cases. Preferable in documentation format but if just in the description of this pull request, it would be awesome! |
Member
|
#31 should go in first and then see what good we can take from this PR in. |
Member
|
@pmvcoelho now please add some tests which prove that your changes work fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Order By in union model select