Fix capability/flow label inconsistencies#619
Fix capability/flow label inconsistencies#619OlivierZal wants to merge 3 commits intoathombv:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a capitalization inconsistency in the fan speed capability definition by changing the English title from "Fan Speed" to "Fan speed", aligning it with the sentence case convention used throughout most other capability definitions in the codebase.
- Changed the English title from "Fan Speed" to "Fan speed" to follow sentence case convention
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @RobinBol, would it be possible to have a look on this one? |
RobinBol
left a comment
RobinBol
left a comment
There was a problem hiding this comment.
Can't really judge if the non NL/EN languages updates are an improvement.
| "type": "number", | ||
| "title": { | ||
| "en": "Fan Speed", | ||
| "en": "Fan speed", |
There was a problem hiding this comment.
I don't think this is an improvement.
There was a problem hiding this comment.
It's for consistency: for other capabilities, English labels have a capital letter only on the first word, not on the other ones.
| "en": "The thermostat mode changed", | ||
| "nl": "De thermostaatmodus is veranderd", |
There was a problem hiding this comment.
Prefer to keep it concise without "The".
There was a problem hiding this comment.
Again for consistency: for other capabilities, there's a "the", like for the non-English labels.
| "en": "The thermostat mode !{{is|is not}}", | ||
| "nl": "De thermostaatmodus !{{is|is niet}}", |
There was a problem hiding this comment.
Prefer to keep it concise without "The".
There was a problem hiding this comment.
Again for consistency: for other capabilities, there's a "the", like for the non-English labels.
|
I'm a French and Polish speaker, who learnt Spanish, and I aligned with other capabilities. |
I guess translations are automated, but here it doesn't deal with translations but with definite/indefinite articles, and/or some harmonization across the labels – within a same capability or beyond.