Open
Conversation
Jimver
commented
May 21, 2024
Author
Jimver
left a comment
Jimver
left a comment
There was a problem hiding this comment.
Feel free to squash merge, was testing out some stuff in between commits
|
Why would someone enable this? |
|
This is just going to hide the GPO switch that turns the outlet on/off, from appearing in HA. So long as it's default = false then won't affect the bulk of users. Would suggest that like any other changes to Smart Plugs, if you want it for one version of plug you should also submit the same changes for the other v1, v2 and v2 (on the ESP32 repository version of Athom) also. |
If you don't want the toggle to control the smart plug to show up in HA, set hide_switch to true. Useful if you only want to monitor but not control the smart plug.
Author
|
Good point @Roving-Ronin! Did the same for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to hide the switch from HA using the
internalproperty.Default is "false" to keep behavior the same as before.