Skip to content

Fix: clamp git actions menu to viewport#562

Merged
mehmetozguldev merged 2 commits intoathasdev:masterfrom
Finesssee:fix/git-actions-menu-clipping
Mar 12, 2026
Merged

Fix: clamp git actions menu to viewport#562
mehmetozguldev merged 2 commits intoathasdev:masterfrom
Finesssee:fix/git-actions-menu-clipping

Conversation

@Finesssee
Copy link
Contributor

@Finesssee Finesssee commented Mar 10, 2026

Fixes #553

Summary

  • anchor the Source Control actions menu to the trigger button instead of raw click coordinates
  • clamp the menu inside the viewport and open upward when there is not enough room below
  • add focused position helper tests for edge and corner placements

Testing

  • bun fix
  • bun typecheck
  • bun test

@mehmetozguldev mehmetozguldev self-requested a review March 12, 2026 15:26
Copy link
Member

@mehmetozguldev mehmetozguldev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed locally. Conflict resolved by preserving the viewport-clamping anchor logic while keeping the shared ContextMenu integration from master. Targeted tests and typecheck passed.

@mehmetozguldev mehmetozguldev merged commit 3d0c230 into athasdev:master Mar 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown menu gets clipped by window

2 participants