Replace simple-git-hooks with pre-commit for unified workflow#226
Replace simple-git-hooks with pre-commit for unified workflow#226piotrmaciejbednarski wants to merge 3 commits intoathasdev:masterfrom
simple-git-hooks with pre-commit for unified workflow#226Conversation
- Configure pre-commit with rustfmt, TypeScript checking, and Biome linting - Replace separate Rust CI and Bun CI workflows with unified pre-commit workflow - Add automatic pre-commit installation via postinstall script - Include commit message validation via commitlint - Optimize for fast CI execution (format-only checks)
2d9ce65 to
4898213
Compare
|
Looks like we can go ahead and merge this |
SnaetWarre
left a comment
There was a problem hiding this comment.
Do we want to bring python in here tho? Can you clarify more why this is a needed change?
I'm not really home in this, can you tell me why we should bring these changes?
Python is only used for The change lets us use more advanced git hooks, which |
|
Also, this pull request fixes the CI workflow, which is super important. Plus, a lot of devs recommend it for Rust projects:
So it's nothing weird or unusual. |
This change migrates from simple-git-hooks to pre-commit for code quality checks, consolidates separate Rust and Bun CI workflows into a single pre-commit workflow, and applies consistent formatting across the codebase.
Changes
rust.ymlandbun.ymlworkflows, replaced with unifiedpre-commit.ymlworkflowsimple-git-hookspackage dependency and related npm scripts.pre-commit-config.yamlwith hooks for Rust (fmt, check), TypeScript (biome, typecheck), and commit message validation.tool-versionsand.venv/to.gitignoreImpact
CONTRIBUTING.mdto reflect new pre-commit setup requirements$ pre-commit run --all-files trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...............................................................Passed check toml...............................................................Passed check json...............................................................Passed check for merge conflicts................................................Passed Rust format (workspace)..................................................Passed Rust check (workspace)...................................................Passed TypeScript check.........................................................Passed Biome check..............................................................PassedRelated Issues
Closes #216