fix(providers): update XunitProvider for xunit.net page structure

- Update HTML table selectors for new page layout
- Select from all tables instead of single article table

Author: Per Kops

src/Atc.CodingRules.AnalyzerProviders/GlobalUsings.cs

@@ -5,6 +5,7 @@
 global using System.Text.Encodings.Web;
 global using System.Text.Json;
 global using System.Text.Json.Serialization;
+global using System.Text.RegularExpressions;
 global using System.Xml;
 
 global using Atc.CodingRules.AnalyzerProviders.Models;

src/Atc.CodingRules.AnalyzerProviders/Providers/XunitProvider.cs

@@ -2,8 +2,8 @@ namespace Atc.CodingRules.AnalyzerProviders.Providers;
 
 public class XunitProvider : AnalyzerProviderBase
 {
-    private const int TableThColumnId = 0;
-    private const int TableTdColumnTitle = 0;
+    private const int TableColumnId = 0;
+    private const int TableColumnTitle = 3;
 
     public XunitProvider(
         ILogger logger,
@@ -30,51 +30,53 @@ protected override async Task ReCollect(AnalyzerProviderBaseRuleData data)
             .LoadFromWebAsync(DocumentationLink!.AbsoluteUri)
             .ConfigureAwait(false);
 
-        var articleNode = htmlDoc.DocumentNode.SelectNodes("//table[@class='table']")[0];
-        var articleTableRows = articleNode
-            .SelectNodes("//*//tr")
-            .ToList();
+        var tables = htmlDoc.DocumentNode.SelectNodes("//table");
+        if (tables is null || tables.Count == 0)
+        {
+            return;
+        }
 
-        foreach (var row in articleTableRows)
+        var articleTableRows = new List<HtmlNode>();
+        foreach (var table in tables)
         {
-            if (row.SelectNodes("th") is null ||
-                row.SelectNodes("td") is null)
+            var rows = table.SelectNodes(".//tr");
+            if (rows is not null)
             {
-                continue;
+                articleTableRows.AddRange(rows);
             }
+        }
 
-            var cellsTh = row
-                .SelectNodes("th")
-                .ToList();
-
-            var cellsTd = row
-                .SelectNodes("td")
-                .ToList();
-
-            if (cellsTh.Count <= 0 || cellsTd.Count <= 0)
+        foreach (var row in articleTableRows)
+        {
+            var rule = TryParseRuleFromRow(row);
+            if (rule is not null)
             {
-                continue;
+                data.Rules.Add(rule);
             }
+        }
+    }
 
-            var aHrefNode = cellsTh[TableThColumnId].SelectSingleNode("a");
-            if (aHrefNode is null)
-            {
-                continue;
-            }
+    private Rule? TryParseRuleFromRow(HtmlNode row)
+    {
+        var cells = row.SelectNodes("td");
+        if (cells is null || cells.Count <= TableColumnTitle)
+        {
+            return null;
+        }
 
-            var code = aHrefNode.InnerText
-                .RemoveNewLines()
-                .Trim();
+        var cellsList = cells.ToList();
+        var aHrefNode = cellsList[TableColumnId].SelectSingleNode("a");
+        if (aHrefNode is null)
+        {
+            return null;
+        }
 
-            var title = HtmlEntity.DeEntitize(cellsTd[TableTdColumnTitle].InnerText);
-            var link = $"{DocumentationLink}/{code}";
+        var code = aHrefNode.InnerText
+            .RemoveNewLines()
+            .Trim();
+        var title = HtmlEntity.DeEntitize(cellsList[TableColumnTitle].InnerText);
+        var link = $"{DocumentationLink}/{code}";
 
-            data.Rules.Add(
-                new Rule(
-                    code,
-                    title,
-                    link,
-                    category: null));
-        }
+        return new Rule(code, title, link, category: null);
     }
 }

test/Atc.CodingRules.AnalyzerProviders.Tests/Providers/XunitProviderTests.cs

@@ -11,11 +11,16 @@ public sealed class XunitProviderTests
     public async Task CollectBaseRules(
         ProviderCollectingMode providerCollectingMode)
     {
-        // Arrange
-        var provider = new XunitProvider(NullLogger.Instance);
+        AnalyzerProviderBaseRuleData? actual = null;
 
-        // Act
-        var actual = await provider.CollectBaseRules(providerCollectingMode);
+        await RetryHelper.ExecuteWithRetryAsync(async () =>
+        {
+            // Arrange
+            var provider = new XunitProvider(NullLogger.Instance);
+
+            // Act
+            actual = await provider.CollectBaseRules(providerCollectingMode);
+        });
 
         // Assert
         Assert.NotNull(actual);