fix(providers): update MicrosoftVisualStudioThreadingAnalyzersProvider URL

- Update DocumentationLink to correct analyzer index page
- Fix href link construction for relative URLs

Author: Per Kops

src/Atc.CodingRules.AnalyzerProviders/Providers/MicrosoftVisualStudioThreadingAnalyzersProvider.cs

@@ -17,7 +17,7 @@ public MicrosoftVisualStudioThreadingAnalyzersProvider(
 
     public static string Name => "Microsoft.VisualStudio.Threading.Analyzers";
 
-    public override Uri? DocumentationLink { get; set; } = new("https://github.com/microsoft/vs-threading/blob/main/doc/analyzers/index.md", UriKind.Absolute);
+    public override Uri? DocumentationLink { get; set; } = new("https://microsoft.github.io/vs-threading/analyzers/index.html", UriKind.Absolute);
 
     protected override AnalyzerProviderBaseRuleData CreateData()
         => new(Name);
@@ -31,20 +31,21 @@ protected override async Task ReCollect(AnalyzerProviderBaseRuleData data)
             .LoadFromWebAsync(DocumentationLink!.AbsoluteUri)
             .ConfigureAwait(false);
 
-        var embeddedNode = htmlDoc.DocumentNode.SelectSingleNode("//script[@data-target='react-app.embeddedData']");
-        if (embeddedNode is not null)
+        var tableNode = htmlDoc.DocumentNode.SelectSingleNode("//table");
+        if (tableNode is null)
         {
-            var dynamicJson = new DynamicJson(embeddedNode.InnerText);
-            var html = dynamicJson.GetValue("payload.blob.richText")?.ToString();
-
-            htmlDoc.LoadHtml(html);
+            return;
         }
 
-        var articleNode = htmlDoc.DocumentNode.SelectNodes("//article[@class='markdown-body entry-content container-lg']")[0];
-        var articleTableRows = articleNode
-            .SelectNodes("//*//table[1]//tr")
+        var articleTableRows = tableNode
+            .SelectNodes(".//tr")?
             .ToList();
 
+        if (articleTableRows is null)
+        {
+            return;
+        }
+
         foreach (var row in articleTableRows)
         {
             if (row.SelectNodes("td") is null)
@@ -69,7 +70,10 @@ protected override async Task ReCollect(AnalyzerProviderBaseRuleData data)
 
             var code = aHrefNode.InnerText;
             var title = HtmlEntity.DeEntitize(cells[TableColumnTitle].InnerText);
-            var link = "https://github.com/" + aHrefNode.Attributes["href"].Value;
+            var hrefValue = aHrefNode.Attributes["href"].Value;
+            var link = hrefValue.StartsWith("http", StringComparison.OrdinalIgnoreCase)
+                ? hrefValue
+                : $"https://microsoft.github.io/vs-threading/analyzers/{hrefValue}";
             var category = cells[TableColumnCategory].InnerText;
 
             data.Rules.Add(

test/Atc.CodingRules.AnalyzerProviders.Tests/GlobalUsings.cs

@@ -1,2 +1,4 @@
+global using System.Diagnostics.CodeAnalysis;
+global using Atc.CodingRules.AnalyzerProviders.Models;
 global using Atc.CodingRules.AnalyzerProviders.Providers;
 global using Microsoft.Extensions.Logging.Abstractions;

test/Atc.CodingRules.AnalyzerProviders.Tests/Providers/MicrosoftVisualStudioThreadingAnalyzersProviderTests.cs

@@ -11,11 +11,16 @@ public sealed class MicrosoftVisualStudioThreadingAnalyzersProviderTests
     public async Task CollectBaseRules(
         ProviderCollectingMode providerCollectingMode)
     {
-        // Arrange
-        var provider = new MicrosoftVisualStudioThreadingAnalyzersProvider(NullLogger.Instance);
+        AnalyzerProviderBaseRuleData? actual = null;
 
-        // Act
-        var actual = await provider.CollectBaseRules(providerCollectingMode);
+        await RetryHelper.ExecuteWithRetryAsync(async () =>
+        {
+            // Arrange
+            var provider = new MicrosoftVisualStudioThreadingAnalyzersProvider(NullLogger.Instance);
+
+            // Act
+            actual = await provider.CollectBaseRules(providerCollectingMode);
+        });
 
         // Assert
         Assert.NotNull(actual);

test/Atc.CodingRules.AnalyzerProviders.Tests/RetryHelper.cs

@@ -0,0 +1,38 @@
+namespace Atc.CodingRules.AnalyzerProviders.Tests;
+
+/// <summary>
+/// Helper class for retrying flaky tests that depend on external services.
+/// </summary>
+public static class RetryHelper
+{
+    /// <summary>
+    /// Executes an async action with retry logic.
+    /// </summary>
+    /// <param name="action">The async action to execute.</param>
+    /// <param name="maxRetries">Maximum number of retry attempts (default is 3).</param>
+    /// <param name="delayBetweenRetriesMs">Delay in milliseconds between retries (default is 1000ms).</param>
+    /// <returns>A task representing the asynchronous operation.</returns>
+    [SuppressMessage("Design", "CA1031:Do not catch general exception types", Justification = "Retry logic needs to catch all exceptions.")]
+    public static async Task ExecuteWithRetryAsync(
+        Func<Task> action,
+        int maxRetries = 3,
+        int delayBetweenRetriesMs = 1000)
+    {
+        ArgumentNullException.ThrowIfNull(action);
+
+        var attempts = 0;
+        while (true)
+        {
+            try
+            {
+                attempts++;
+                await action();
+                return;
+            }
+            catch when (attempts < maxRetries)
+            {
+                await Task.Delay(delayBetweenRetriesMs);
+            }
+        }
+    }
+}