Add filtrex example of detecting mod options#925
Open
rossjrw wants to merge 2 commits intoatampy25:mainfrom
Open
Add filtrex example of detecting mod options#925rossjrw wants to merge 2 commits intoatampy25:mainfrom
rossjrw wants to merge 2 commits intoatampy25:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filtrex's
ofsyntax (Y of Xis syntactic sugar forX.Y) enables conditional options to detect complex mod option combinations which are otherwise impossible becausemodOptions["Username.ModName"]is not syntax that exists in filtrex, andmodOptions.Username.ModNamedoesn't work for obvious reasons. But, this isn't at all obvious from the example in the docs - not to mention that the linked filtrex documentation is an abandoned repo that doesn't mention this syntax, and it isn't even the filtrex npm package that SMF uses.This PR updates the filtrex expression docs link to point to the repo that provides the npm package, and adds an example of detecting mod option combinations.