Skip to content

UI: remove useTrigger from TriggerDAGForm#1566

Closed
Lee-W wants to merge 5 commits intomainfrom
cursor/materialize-trigger-distinction-e159
Closed

UI: remove useTrigger from TriggerDAGForm#1566
Lee-W wants to merge 5 commits intomainfrom
cursor/materialize-trigger-distinction-e159

Conversation

@Lee-W
Copy link
Copy Markdown

@Lee-W Lee-W commented Mar 26, 2026

Why

Address review feedback in apache#64211 while keeping materialize and trigger separate and avoiding callback/type confusion.

What

  • Kept TriggerDAGModal.tsx unchanged.
  • Simplified TriggerDAGForm.tsx to use a single callback prop: onSubmitTrigger.
  • Removed unused onTrigger compatibility path after confirming no call sites use it.
  • Preserved submit behavior: pause toggle (if checked) then onSubmitTrigger invocation.
  • Keeps TypeScript clean without possibly undefined callback invocation.

Validation

  • pnpm run lint (in airflow-core/src/airflow/ui)

Was generative AI tooling used to co-author this PR?
  • Yes — GPT-5 Codex

Generated-by: GPT-5 Codex following the guidelines

Open in Web Open in Cursor 

cursoragent and others added 5 commits March 26, 2026 11:08
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@Lee-W Lee-W closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants