Make the Unix build truly relocatable as CPython patch #923
+148
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmathematica
commented
Dec 16, 2025
cpython-unix/build-cpython.sh
Outdated
| "python_exe": "install/bin/python%s%s" % (sysconfig.get_python_version(), sys.abiflags), | ||
| "python_major_minor_version": sysconfig.get_python_version(), | ||
| "python_stdlib_platform_config": sysconfig.get_config_var("LIBPL").lstrip("/"), | ||
| "python_stdlib_platform_config": sysconfig.get_config_var("LIBPL"), |
Author
There was a problem hiding this comment.
As as consequence of this change, "python_stdlib_platform_config" will be absolute path instead of relative path. It looks we'd better adopt this change and change doc, instead of trying to force it to remain relative.
If this chane is adopted, update_sysconfig function from https://github.com/astral-sh/uv/blob/13e7ad62cb0d3ca8bf5eeee407d658d6d887d5f9/crates/uv-python/src/sysconfig/mod.rs#L44 can be removed altogether.
mrmathematica
commented
Dec 17, 2025
| if info.get("build-mode") == "shared": | ||
| shared_dir = extra_metadata["python_config_vars"]["DESTSHARED"].strip("/") | ||
| shared_dir = extra_metadata["python_config_vars"]["DESTSHARED"] | ||
| shared_dir = shared_dir[shared_dir.find("install"):] |
Author
There was a problem hiding this comment.
I see tests fail, and peiced this as a hack for pass. Would need some proper suggestion on what should be done for paths like those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #857