Skip to content

fix: Avoid panics when content is longer than content length header #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konstin wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Avoid panics when content is longer than content length header #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bba9d11
Avoid panics when content is longer than content length header
konstin Mar 5, 2026
785c99f
Update src/lib.rs
konstin Mar 9, 2026
7d6c1dc
Review
konstin Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,31 @@ pub enum AsyncHttpRangeReaderError {
MemoryMapError(#[source] Arc<std::io::Error>),

/// Error from `http-content-range`
#[error("Invalid Content-Range header: {0}")]
#[error("invalid Content-Range header: {0}")]
ContentRangeParser(String),

/// The server returned an invalid range response
#[error(
"request and response range mismatch, \
expected {expected_start}-{expected_end_inclusive}/{expected_complete_length}, \
got {actual_start}-{actual_end_inclusive}/{actual_complete_length}"
)]
RangeMismatch {
expected_start: u64,
expected_end_inclusive: u64,
expected_complete_length: usize,
actual_start: u64,
actual_end_inclusive: u64,
actual_complete_length: u64,
},

/// The server returned more bytes than the range request asked for
#[error("range response returned more than the expected {expected} bytes")]
ResponseTooLong { expected: u64 },

/// The server returned fewer bytes than the range request asked for
#[error("expected {expected} bytes from range response, got {actual}")]
ResponseTooShort { expected: u64, actual: u64 },
}

impl From<std::io::Error> for AsyncHttpRangeReaderError {
Expand Down
Loading