Bring segment.rs back into alignment with original#439
Open
SNoAnd wants to merge 347 commits intoasterinas:mainfrom
Open
Bring segment.rs back into alignment with original#439SNoAnd wants to merge 347 commits intoasterinas:mainfrom
SNoAnd wants to merge 347 commits intoasterinas:mainfrom
Conversation
…-fv into phaseII/verified
…t the `GlobalMemView` is complete (no floating `MemView` objects)
…-fv into phaseII/verified
…-fv into phaseII/verified
…-fv into phaseII/verified
…eir own functions.
…g about all nodes
…y pass the build check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on eliminating transcription issues in
segment.rs. It also refactors the permission structure ofSegmentOwnerto carry borrowed slot owners/perms instead of values, preventing duplication. We can do a similar refactor in linked_list later. The remaining work onio.rswill be next.Github has the whole stack of commits listed again here, I guess because there was still some
phaseII/verifiedhistory involved, but after this we'll stick to main.