Skip to content

Accessibilty Issues- Generic feature/RMA-91480. #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hemanth3843 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Accessibilty Issues- Generic feature/RMA-91480. #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/dxc-ngx-cdk/src/lib/dxc-button/dxc-button.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
attr.aria-labelledby="{{ariaLabelledBy}}"
attr.aria-describedby="{{ariaDescribedBy}}"
>
<img
<img aria-hidden="true"
src="{{ iconSrc }}"
*ngIf="iconSrc"
/>
Expand Down
3 changes: 2 additions & 1 deletion projects/dxc-ngx-cdk/src/lib/dxc-page-errors/dxc-page-errors.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ import { AbstractControlDirective, AbstractControl } from '@angular/forms';
selector: 'dxc-show-errors',
template: `
<ul *ngIf="shouldShowErrors()" class="position-absolute">
<li style="color: red" *ngFor="let error of listOfErrors()">{{error}}</li>
<li style="color: red" *ngFor="let error of listOfErrors()">
<div role="alert" tabindex="0">{{error}}</div></li>
</ul>
`,
})
Expand Down
5 changes: 5 additions & 0 deletions projects/dxc-ngx-cdk/src/lib/dxc-paginator/dxc-paginator.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
[iconSrc]="firstImgSrc"
[disabled]="currentPageInternal === 1"
[tabIndexValue]="tabIndexValue"
ariaLabel="{{globalResource.tltfirstPage?.description}}"
></dxc-button>
<dxc-button
*ngIf="showPrev"
Expand All @@ -40,6 +41,8 @@
[iconSrc]="prevImgSrc"
[disabled]="currentPageInternal === 1"
[tabIndexValue]="tabIndexValue"
ariaLabel="{{globalResource.tltPreviousPage?.description}}"

></dxc-button>
<span class="text-nowrap" *ngIf="!showGoToPage"> Page: {{ currentPageInternal }} of {{ totalPages }} </span>
<span *ngIf="showGoToPage" class="go-to-page">
Expand Down Expand Up @@ -67,6 +70,7 @@
[iconSrc]="nextImgSrc"
[disabled]="currentPageInternal === totalPages"
[tabIndexValue]="tabIndexValue"
ariaLabel="{{globalResource.tltnextPage?.description}}"
>
</dxc-button>
<dxc-button
Expand All @@ -78,6 +82,7 @@
[iconSrc]="lastImgSrc"
[disabled]="currentPageInternal === totalPages"
[tabIndexValue]="tabIndexValue"
ariaLabel="{{globalResource.tltLastPage?.description}}"
>
</dxc-button>
</div>
Expand Down
7 changes: 6 additions & 1 deletion projects/dxc-ngx-cdk/src/lib/dxc-paginator/dxc-paginator.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@ import {
import { BehaviorSubject } from "rxjs";
import { coerceNumberProperty, coerceArray } from "@angular/cdk/coercion";
import { css } from "emotion";
import { ConfigurationsetupService } from './../services/startup/configurationsetup.service';

@Component({
selector: "dxc-paginator",
templateUrl: "./dxc-paginator.component.html",
styleUrls: ["./dxc-paginator.component.scss"],
})
export class DxcPaginatorComponent implements OnInit {
globalResource: { [key: string]: { description: string, type: string } };
@Input()
get currentPage(): number {
return this._currentPage;
Expand Down Expand Up @@ -100,13 +102,16 @@ export class DxcPaginatorComponent implements OnInit {
tabIndexValue: 0
});

constructor() {
constructor(
public config: ConfigurationsetupService,
) {
this.currentPage = 1;
this.itemsPerPage = 5;
this.totalItems = 1;
}

ngOnInit() {
this.globalResource = this.config.configservice.Resources;
this.calculateInternalValues(this.defaultInputs.getValue());
this.setButtonVisibility(this.paginationActions);
this.className = `${this.getDynamicStyle()}`;
Expand Down