Skip to content

Upgrade PHPStan to level 8, add tests/ to paths, fix types#15

Merged
sylfabre merged 3 commits intomainfrom
fix/phpstan-rector
Mar 22, 2026
Merged

Upgrade PHPStan to level 8, add tests/ to paths, fix types#15
sylfabre merged 3 commits intomainfrom
fix/phpstan-rector

Conversation

@sylfabre
Copy link
Copy Markdown
Contributor

Summary

  • Removed level: 6 override from phpstan.neon.dist (now uses default level 8)
  • Added tests/ to PHPStan and Rector paths
  • Fixed 69 $this->assert*()self::assert*() calls in tests
  • Fixed type issues in DTOs (optional offset access, Currency non-empty-string, getData return types)
  • Fixed TransactionIterator null check
  • 32 errors baselined (DTO array shape mismatches from json_decode, already-narrowed assertions)

Test plan

  • Rector clean
  • PHPStan 0 errors (32 baselined)
  • PHPUnit passes (62 tests, 111 assertions)

🤖 Generated with Claude Code

@sonarqubecloud
Copy link
Copy Markdown

2 similar comments
@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

@sylfabre sylfabre force-pushed the fix/phpstan-rector branch from 6866eb8 to b725352 Compare March 22, 2026 09:38
sylfabre and others added 3 commits March 22, 2026 10:56
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sylfabre sylfabre force-pushed the fix/phpstan-rector branch from e088bfd to a85bac7 Compare March 22, 2026 09:57
@sonarqubecloud
Copy link
Copy Markdown

@sylfabre sylfabre merged commit c1e1f5c into main Mar 22, 2026
6 checks passed
@sylfabre sylfabre deleted the fix/phpstan-rector branch March 22, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant