Add AGENTS.md with project context and upstream PR notes#4
Merged
assisted-by-ai merged 3 commits intomasterfrom Apr 10, 2026
Merged
Add AGENTS.md with project context and upstream PR notes#4assisted-by-ai merged 3 commits intomasterfrom
assisted-by-ai merged 3 commits intomasterfrom
Conversation
Annotate _s_out() with __printf(2, 3) so the compiler warns on format string mismatches. Also mark fmt parameter as const since it is not modified. https://claude.ai/code/session_018RqemCaZDrhmA7jV2eBgQ3
The Kicksecure#3 maintainer feedback is that the __printf attribute change is too pedantic for a module this small. Record this so future agents don't re-propose it. https://claude.ai/code/session_018RqemCaZDrhmA7jV2eBgQ3
assisted-by-ai
pushed a commit
that referenced
this pull request
Apr 10, 2026
Add documentation of the rejected compiler warning flags PR (#4) so future agents don't re-propose hardcoding ccflags-y in the module Makefile. Kbuild already handles warning flags for modules. https://claude.ai/code/session_01TGuvnh5mbFAcuVWNxMcuKP
2 tasks
assisted-by-ai
pushed a commit
that referenced
this pull request
Apr 17, 2026
commit e1cc04e Author: Claude <noreply@anthropic.com> Date: Fri Apr 10 10:39:05 2026 +0000 Update AGENTS.md with PR #4 rejection notes Add documentation of the rejected compiler warning flags PR (#4) so future agents don't re-propose hardcoding ccflags-y in the module Makefile. Kbuild already handles warning flags for modules. https://claude.ai/code/session_01TGuvnh5mbFAcuVWNxMcuKP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mddocumenting project overview and build instructions__printfformat attribute annotation on_s_out()was deemed too pedantic for a module this smallNo source code changes
Only
AGENTS.mdis added. Themodule/tirdad.csource is untouched.https://claude.ai/code/session_018RqemCaZDrhmA7jV2eBgQ3